Skip to content

disagg: Suppress enum overflow warning on S3 SDK (#9957)#9978

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9957-to-release-8.5
Mar 28, 2025
Merged

disagg: Suppress enum overflow warning on S3 SDK (#9957)#9978
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9957-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9957

What problem does this PR solve?

Issue Number: close #9955

Problem Summary: logging flood may cause other important logging being lost when the logging collector is not able to collect all logging in time.

What is changed and how it works?

Apply a patch to suppress enum overflow warning on S3 SDK. And we may upgrade the S3 SDK in later PRs

disagg: Suppress enum overflow warning on S3 SDK

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Suppress a logging that report unknown enum from S3

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Mar 11, 2025
…p#9995)

close pingcap#9955

disagg: Fix build under ASAN; Check each aws patch separately
* Use "${AWS_SDK_DIR}" as working directory

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-28 01:37:24.065052833 +0000 UTC m=+1183537.749288926: ☑️ agreed by JaySon-Huang.
  • 2025-03-28 01:50:48.960586409 +0000 UTC m=+1184342.644822502: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 09e07b1 into pingcap:release-8.5 Mar 28, 2025
4 checks passed
JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Mar 31, 2025
…cap#9978)

close pingcap#9955

disagg: Suppress enum overflow warning on S3 SDK

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants