Skip to content

disagg: Suppress enum overflow warning on S3 SDK#9957

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
JaySon-Huang:suppress_s3_enum_overflow
Mar 7, 2025
Merged

disagg: Suppress enum overflow warning on S3 SDK#9957
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
JaySon-Huang:suppress_s3_enum_overflow

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Mar 6, 2025

What problem does this PR solve?

Issue Number: close #9955

Problem Summary: logging flood may cause other important logging being lost when the logging collector is not able to collect all logging in time.

What is changed and how it works?

Apply a patch to suppress enum overflow warning on S3 SDK. And we may upgrade the S3 SDK in later PRs

disagg: Suppress enum overflow warning on S3 SDK

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Suppress a logging that report unknown enum from S3

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-07 01:59:02.076439511 +0000 UTC m=+579655.205359249: ☑️ agreed by JinheLin.
  • 2025-03-07 02:17:17.575858624 +0000 UTC m=+580750.704778365: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit 34dc79b into pingcap:master Mar 7, 2025
5 checks passed
@JaySon-Huang JaySon-Huang deleted the suppress_s3_enum_overflow branch March 7, 2025 03:22
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 11, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9978.

@pingcap pingcap deleted a comment from ti-chi-bot bot Mar 14, 2025
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 27, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Mar 28, 2025
close #9955

disagg: Suppress enum overflow warning on S3 SDK

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Mar 31, 2025
…cap#9978)

close pingcap#9955

disagg: Suppress enum overflow warning on S3 SDK

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
yongman pushed a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
close pingcap#9955

disagg: Suppress enum overflow warning on S3 SDK

Signed-off-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws s3 cause logging flood "Encountered enum member CRC64NVME which is not modeled in your clients"

4 participants