vector: Fix the bug that the local index in CFTiny is not removed during MinorCompaction#9945
Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom Mar 6, 2025
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Member
|
Curious how did you find this issue? |
JinheLin
approved these changes
Mar 6, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger
approved these changes
Mar 6, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Mar 6, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
JaySon-Huang
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Mar 31, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
…ing MinorCompaction (#9945) (#9951) close #9946 vector: Fix the bug that the local index in CFTiny is not removed during MinorCompaction Add test cases about the removing page_id when doing MinorCompaction Add test cases about querying the ColumnFileTiny in DeltaVS with VectorIndex could filter the return rows Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
…ing MinorCompaction (pingcap#9945) close pingcap#9946 vector: Fix the bug that the local index in CFTiny is not removed during MinorCompaction Add test cases about the removing page_id when doing MinorCompaction Add test cases about querying the ColumnFileTiny in DeltaVS with VectorIndex could filter the return rows Signed-off-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9946
Problem Summary:
Some pages for local index in the ColumnFileTiny is not removed when doing MinorCompaction
tiflash/dbms/src/Storages/DeltaMerge/Delta/MinorCompaction.cpp
Lines 53 to 54 in 6fec03d
In
MinorCompaction::preparewe usewbs.removed_log.delPage(t_file->getDataPageId());to remove the ColumnFileTiny. But this will not remove the related LocalIndex page_id with the ColumnFileTiny. We must uset_file->removeData(wbs);to remove the ColumnFileTiny along with its LocalIndex page_ids.BTW,
SegmentSplit,SegmentMergeandSegmentDeltaMerge(MajorCompaction) callsDeltaValueSpace::recordRemoveColumnFilesPagesand can correctly remove the LocalIndex page_ids.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note