disagg: Add exclusive label for tiflash compute node (release-8.1)#9893
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.1from Feb 20, 2025
Merged
Conversation
close pingcap#9750 Add a label with {"exclusive": "no-data"}, so that PD won't select TiFlash compute node stores for placing Region Signed-off-by: JaySon-Huang <tshent@qq.com>
JinheLin
approved these changes
Feb 19, 2025
Lloyd-Pottiger
approved these changes
Feb 20, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Apr 25, 2025
…ingcap#9893) close pingcap#9750 Add a label with {"exclusive": "no-data"}, so that PD won't select TiFlash compute node stores for placing Region Signed-off-by: JaySon-Huang <tshent@qq.com>
12 tasks
JaySon-Huang
added a commit
that referenced
this pull request
Apr 25, 2025
…#10134) Note: * This change to the FFI interface for proxy adaptation. And the related issue is currently suspected to potentially cause fluctuations in LearnerRead latency in some cases. #9841, #9882 * This change to the FFI interface for proxy adaptation #9893 * Fix stale read can not eliminate the learner read #10132 ### What problem does this PR solve? Issue Number: ref #4982, close #10046 Problem Summary: update proxy to raftstore-proxy-8.1 Proxy PR: Including:\nSubmodule contrib/tiflash-proxy caa7a0c1dd..96545a2632: > Fix safe ts not updated (#429) (#434) The leader_safe_ts, self_safe_ts are always 0 in the TiFlash side, making TiFlash can not eliminate the learner read on region without any updates. ### What is changed and how it works? For detailed reasons why safe_ts failed to be updated, checkout the description on pingcap/tidb-engine-ext#429. ### Check List Tests <!-- At least one of them must be included. --> - [ ] Unit test - [ ] Integration test - [x] Manual test (add detailed scripts or steps below) - [ ] No code Side effects - [ ] Performance regression: Consumes more CPU - [ ] Performance regression: Consumes more Memory - [ ] Breaking backward compatibility Documentation - [ ] Affects user behaviors - [ ] Contains syntax changes - [ ] Contains variable changes - [ ] Contains experimental features - [ ] Changes MySQL compatibility ### Release note <!-- bugfix or new feature needs a release note --> ```release-note Fix the issue that `SELECT ... AS OF TIMESTAMP` can not eliminate the learner read on TiFlash as expected ``` --------- Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Signed-off-by: CalvinNeo <calvinneo1995@gmail.com> Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #9849
What problem does this PR solve?
Issue Number: close #9750
Problem Summary:
When creating a placement policy through tidb, tidb will create a placement-rule with
"engine" notIn "tiflash"pingcap/tidb#22065However, under tiflash disaggregated compute and storage arch, the compute node will register store with label
{"engine": "tiflash_compute"}.The logic in PD of choosing store for rule: pkg/schedule/placement/label_constraint.go @ pd
So the PD would pick tiflash compute node as target store to place the Region peer.
What is changed and how it works?
We avoid Region data being placed to TiFlash compute node in 2 ways:
--engine-role-labelfrom proxy args, use--labelsinstead--labelswon't overwrite theserver.labelsin tiflash_tikv.toml, instead, proxy append the extra labels toserver.labelsCheck List
Tests
Side effects
Documentation
Release note