Fix safe ts not updated#429
Merged
ti-chi-bot[bot] merged 7 commits intopingcap:raftstore-proxyfrom Mar 27, 2025
Merged
Conversation
Member
Author
|
/hold need manual test |
Member
Author
|
Tesed over pingcap/tiflash#10007
|
Member
Author
|
/unhold |
Collaborator
JaySon-Huang
left a comment
There was a problem hiding this comment.
IMO, some functions should return false according to the semantic
Comment on lines
+225
to
+227
| } else { | ||
| true | ||
| } |
Collaborator
There was a problem hiding this comment.
ditto
tidb-engine-ext/components/raftstore/src/coprocessor/dispatcher.rs
Lines 903 to 906 in b99342a
Suggested change
| } else { | |
| true | |
| } | |
| } else { | |
| false | |
| } |
Member
Author
There was a problem hiding this comment.
/// Should be called everytime before we want to write apply state when
/// applying. Return a bool which indicates whether we can actually do
/// this write.
fn pre_write_apply_state(&self, _: &mut ObserverContext<'_>) -> bool {
true
}
The default returning value of pre_write_apply_state is true.
Comment on lines
+217
to
+219
| } else { | ||
| true | ||
| } |
Collaborator
There was a problem hiding this comment.
IMO, it should return false according to the semantic
tidb-engine-ext/components/raftstore/src/coprocessor/dispatcher.rs
Lines 883 to 887 in b99342a
Suggested change
| } else { | |
| true | |
| } | |
| } else { | |
| false | |
| } |
Member
Author
There was a problem hiding this comment.
/// Should be called everytime before we write a WriteBatch into
/// KvEngine. Returns false if we can't commit at this time.
fn pre_persist(
&self,
_: &mut ObserverContext<'_>,
_is_finished: bool,
_cmd: Option<&RaftCmdRequest>,
) -> bool {
true
}
Comment on lines
+235
to
+237
| } else { | ||
| true | ||
| } |
Collaborator
There was a problem hiding this comment.
ditto
tidb-engine-ext/components/raftstore/src/coprocessor/dispatcher.rs
Lines 924 to 925 in b99342a
Suggested change
| } else { | |
| true | |
| } | |
| } else { | |
| false | |
| } |
Member
Author
There was a problem hiding this comment.
pub trait RaftMessageObserver: Coprocessor {
/// Returns false if the message should not be stepped later.
fn on_raft_message(&self, _: &RaftMessage) -> bool {
true
}
}
JaySon-Huang
approved these changes
Mar 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
CalvinNeo
added a commit
to CalvinNeo/tidb-engine-ext
that referenced
this pull request
Apr 23, 2025
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
CalvinNeo
added a commit
to CalvinNeo/tidb-engine-ext
that referenced
this pull request
Apr 23, 2025
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
This was referenced Apr 24, 2025
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
ref pingcap/tiflash#10046 Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
CalvinNeo
added a commit
that referenced
this pull request
Apr 24, 2025
This was referenced Apr 24, 2025
JaySon-Huang
added a commit
to pingcap/tiflash
that referenced
this pull request
Apr 25, 2025
…#10134) Note: * This change to the FFI interface for proxy adaptation. And the related issue is currently suspected to potentially cause fluctuations in LearnerRead latency in some cases. #9841, #9882 * This change to the FFI interface for proxy adaptation #9893 * Fix stale read can not eliminate the learner read #10132 ### What problem does this PR solve? Issue Number: ref #4982, close #10046 Problem Summary: update proxy to raftstore-proxy-8.1 Proxy PR: Including:\nSubmodule contrib/tiflash-proxy caa7a0c1dd..96545a2632: > Fix safe ts not updated (#429) (#434) The leader_safe_ts, self_safe_ts are always 0 in the TiFlash side, making TiFlash can not eliminate the learner read on region without any updates. ### What is changed and how it works? For detailed reasons why safe_ts failed to be updated, checkout the description on pingcap/tidb-engine-ext#429. ### Check List Tests <!-- At least one of them must be included. --> - [ ] Unit test - [ ] Integration test - [x] Manual test (add detailed scripts or steps below) - [ ] No code Side effects - [ ] Performance regression: Consumes more CPU - [ ] Performance regression: Consumes more Memory - [ ] Breaking backward compatibility Documentation - [ ] Affects user behaviors - [ ] Contains syntax changes - [ ] Contains variable changes - [ ] Contains experimental features - [ ] Changes MySQL compatibility ### Release note <!-- bugfix or new feature needs a release note --> ```release-note Fix the issue that `SELECT ... AS OF TIMESTAMP` can not eliminate the learner read on TiFlash as expected ``` --------- Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Signed-off-by: CalvinNeo <calvinneo1995@gmail.com> Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: ref pingcap/tiflash#10046
The problem is that
coprocessor_hostisCopy. However, theCopytrait is derived. So different copies ofcoprocessor_hostare separated instances.So we have to move
tiflash_ob.register_toto a much earlier stage.What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note