support tidb truncate function#9842
Merged
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom Feb 11, 2025
Merged
Conversation
78f3918 to
94fe3cd
Compare
94fe3cd to
4edc751
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
4edc751 to
c9e1895
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
guo-shaoge
commented
Feb 7, 2025
yibin87
reviewed
Feb 8, 2025
65da584 to
1a9c7d8
Compare
777eff2 to
fc61386
Compare
gengliqi
reviewed
Feb 10, 2025
| // modified from <https://github.com/pingcap/tidb/blob/26237b35f857c2388eab46f9ee3b351687143681/types/helper.go#L33-L48>. | ||
|
|
||
| // modified from https://github.com/pingcap/tidb/blob/26237b35f857c2388eab46f9ee3b351687143681/types/helper.go#L33-L48 and | ||
| // https://github.com/pingcap/tidb/blob/26237b35f857c2388eab46f9ee3b351687143681/types/helper.go#L50-L61. |
Contributor
There was a problem hiding this comment.
Seems that ConstPowOf10 can be used to optimize the code in Line 986 base = std::pow(10.0, frac)
Contributor
Author
There was a problem hiding this comment.
It needs more efforts to make sure correctness and performance improvement. Maybe we should to it in another pr
gengliqi
approved these changes
Feb 11, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9846
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note