improve performance for round(col_floating, frac) #9860

New issue

Copy link

New issue

Copy link

Open

Open

improve performance for round(col_floating, frac)#9860

Copy link

Labels

component/computetype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.

Description

guo-shaoge

opened on Feb 11, 2025

Issue body actions

Enhancement

For now, TiDBFloatingRound use std::pow to compute base, which may hurt performance. Should use pre-computed array, like TiDBDecimalRound and TiDBIntegerRound, check

tiflash/dbms/src/Functions/FunctionsRound.h

Line 1032 in 0001db3

using Pow = ConstPowOf10<UnsignedOutput, digits>;

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

Labels

component/computetype/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions