Skip to content

pushdown tidb truncate to tiflash #9846

New issue
New issue
Closed
#9842
Closed
pushdown tidb truncate to tiflash#9846
#9842
Labels
type/enhancementThe issue or PR belongs to an enhancement.
@guo-shaoge

Description

@guo-shaoge
guo-shaoge
opened on Feb 6, 2025

Enhancement

For now tiflash truncate use ClickHouse code, the first argument cannot be Decimal(check

tiflash/dbms/src/Flash/Coprocessor/DAGUtils.cpp

Line 314 in 1697c72

//{tipb::ScalarFuncSig::TruncateDecimal, "cast"},
), and the second argument can only be constant(check

tiflash/dbms/src/Functions/FunctionsRound.h

Line 686 in 1697c72

if (!scale_column.isColumnConst())
). (which is ok for floor/ceil because they only support one argument, but not ok for truncate, because it support two arguments).

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/enhancementThe issue or PR belongs to an enhancement.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions