Skip to content

Fix the incompatible behavior when handling IN(Timestamp | MysqlTime * ) expressions with timezone#9779

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
solotzg:fix-tidb-57652
Jan 10, 2025
Merged

Fix the incompatible behavior when handling IN(Timestamp | MysqlTime * ) expressions with timezone#9779
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
solotzg:fix-tidb-57652

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Jan 10, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9778

Problem Summary:

  • DAGExpressionAnalyzer hasn't deal with timezone when handling set for IN() express.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the bug of incorrect result when handling IN(Timestamp | Time * ) expressions with timezone

solotzg added 2 commits January 9, 2025 22:06
@solotzg
fix
2f1f20a 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg
add tests
e6eeec5 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 10, 2025
@solotzg
Copy link
Contributor Author

solotzg commented Jan 10, 2025

/test pull-unit-test

@solotzg
fix test
0a7aab4 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg
*
56000c7 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg solotzg self-assigned this Jan 10, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 10, 2025
zanmato1984
zanmato1984 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this!

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,zanmato1984]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-10 05:07:07.562052125 +0000 UTC m=+502970.850883830: ☑️ agreed by zanmato1984.
  • 2025-01-10 05:14:48.833190116 +0000 UTC m=+503432.122021821: ☑️ agreed by gengliqi.

@ti-chi-bot ti-chi-bot bot merged commit 265b329 into pingcap:master Jan 10, 2025
@solotzg solotzg deleted the fix-tidb-57652 branch January 10, 2025 06:45
@solotzg
Copy link
Contributor Author

solotzg commented Jan 24, 2025

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2025

@solotzg: new pull request created to branch release-8.5: #9826.

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Closed
12 tasks
@solotzg
Copy link
Contributor Author

solotzg commented Jan 24, 2025

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2025

@solotzg: new pull request created to branch release-8.1: #9827.

Details

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Closed
12 tasks
@solotzg
Copy link
Contributor Author

solotzg commented Jan 24, 2025

/cherry-pick release-7.5

@solotzg
Copy link
Contributor Author

solotzg commented Jan 24, 2025

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2025

@solotzg: new pull request created to branch release-7.5: #9828.

Details

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2025

@solotzg: new pull request created to branch release-7.1: #9829.

Details

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 24, 2025
@solotzg @ti-chi-bot
This is an automated cherry-pick of pingcap#9779
a7c8014 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@solotzg solotzg

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatible results with MySQL when handling IN(Timestamp | MysqlTime ) expressions with timezone

4 participants

@solotzg @ti-chi-bot @zanmato1984 @gengliqi