Skip to content

Fix the incompatible behavior when handling IN(Timestamp | MysqlTime * ) expressions with timezone (#9779)#9826

Closed
ti-chi-bot wants to merge 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9779-to-release-8.5
Closed

Fix the incompatible behavior when handling IN(Timestamp | MysqlTime * ) expressions with timezone (#9779)#9826
ti-chi-bot wants to merge 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9779-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 24, 2025

This is an automated cherry-pick of #9779

What problem does this PR solve?

Issue Number: close #9778

Problem Summary:

  • DAGExpressionAnalyzer hasn't deal with timezone when handling set for IN() express.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the bug of incorrect result when handling IN(Timestamp | Time * ) expressions with timezone

@solotzg @ti-chi-bot
fix
b1dfc06 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
add tests
493dffe 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
fix test
ab9dd99 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
*
718601e 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 24, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg solotzg requested a review from gengliqi January 24, 2025 06:50
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, solotzg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-24 06:50:54.743656033 +0000 UTC m=+422782.074575614: ☑️ agreed by solotzg.
  • 2025-01-24 06:52:34.688846517 +0000 UTC m=+422882.019765915: ☑️ agreed by gengliqi.

@solotzg
Copy link
Contributor

solotzg commented Jan 24, 2025

/test pull-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

@solotzg: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-integration-test

/test pull-unit-test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg
Copy link
Contributor

solotzg commented Jan 24, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solotzg solotzg solotzg approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

@solotzg solotzg

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @solotzg @gengliqi