Aggregator support batch serialize#9777
Merged
ti-chi-bot[bot] merged 54 commits intopingcap:masterfrom Mar 10, 2025
Merged
Conversation
ff696d3 to
8bbb062
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
30a5b1c to
241537d
Compare
fc95526 to
3354b7f
Compare
guo-shaoge
commented
Feb 4, 2025
guo-shaoge
commented
Feb 4, 2025
…ize_refine Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
yibin87
reviewed
Feb 27, 2025
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
windtalker
reviewed
Mar 7, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
guo-shaoge
added a commit
to guo-shaoge/tiflash
that referenced
this pull request
Mar 11, 2025
This reverts commit 67438e8.
guo-shaoge
added a commit
to guo-shaoge/tiflash
that referenced
this pull request
Mar 25, 2025
This reverts commit 67438e8. Signed-off-by: guo-shaoge <shaoge1994@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9692
Problem Summary: Reduce virtual function call for
key_serializeandkey_string.Workload: tpch-50g
Queries: same with #9679
Workload: clickbench
Queries: https://github.com/ClickHouse/ClickBench/blob/fdfdb5d94f2a668dce1f63d55498aa34510e4c9c/clickhouse/queries.sql#L11
NOTE:
two_keys_num64_strbinpadding. opt key iskey_serialized.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note