Aggregator support prefetch#9679
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
/retest |
| Mapped * value = nullptr; | ||
| Mapped * cached_value = nullptr; | ||
| bool inserted = false; |
There was a problem hiding this comment.
What specific issue does this change address?
There was a problem hiding this comment.
emplace_result_holder (std::optional< EmplaceResult >) needs copy assign operator
Signed-off-by: guo-shaoge <shaoge1994@163.com>
| } | ||
| else | ||
| { | ||
| emplace_result.setMapped(place); |
There was a problem hiding this comment.
Is it save to push the fake address?
There was a problem hiding this comment.
it's ok. no one use value if agg func is zero. Also check: https://github.com/ClickHouse/ClickHouse/blob/70945668f81a3621685edf4d21728efc1ae4a902/src/Interpreters/Aggregator.cpp#L1020
There was a problem hiding this comment.
Add a comment like clickhouse dose before auto * place = reinterpret_cast<AggregateDataPtr>(0x1);?
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
/retest |
| } | ||
| else | ||
| { | ||
| emplace_result.setMapped(place); |
There was a problem hiding this comment.
Add a comment like clickhouse dose before auto * place = reinterpret_cast<AggregateDataPtr>(0x1);?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/hold |
This reverts commit 999018c. Signed-off-by: guo-shaoge <shaoge1994@163.com>
What problem does this PR solve?
Issue Number: close #9680
Problem Summary:
What is changed and how it works?
key32/key64/key128/key256, and it doesn't affectkey_string/key_serializedBenchmark
Workloads:
TPCH-50GQueries:
ENV:
Results (google excel):
NOTE:
1.1 Query duration is in seconds
1.2 baseline: nightly-b16a5f93; rate-opt2: (baseline - opt2)/baseline
SELECT COUNT(DISTINCT UserID) FROM hits;https://github.com/ClickHouse/ClickBench/blob/main/mysql/queries.sqlCheck List
Tests
Side effects
Documentation
Release note