Storages: fix the range of load DMFilePackFilterResult#9755
Storages: fix the range of load DMFilePackFilterResult#9755ti-chi-bot[bot] merged 11 commits intopingcap:masterfrom
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
|
We should add more unit-tests to cover this issue. |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
| } | ||
| CATCH | ||
|
|
||
| TEST_P(DeltaMergeStoreRWTest, ReadAfterLogicalSplit) |
There was a problem hiding this comment.
Add a test to cover this case.
Without the fix in Segment.cpp, this case will report error as below
/DATA/disk1/jaysonhuang/tiflash/dbms/src/Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp:590: Failure
(in).read() return more rows(49152) than expected
(createColumns({ createColumn<Int64>(createNumbers<Int64>(0, num_rows_write)), })).rows()
Which is: 24576
|
/cc @CalvinNeo @JinheLin PTAL |
|
@JaySon-Huang: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-unit-test |
…ingcap#9755) pingcap#9755 Signed-off-by: Wish <breezewish@outlook.com>
What problem does this PR solve?
Issue Number: close #9754
Problem Summary:
Introduced by #9738
What is changed and how it works?
After #9738, we load the pack_filter_result in
Segment::getInputStream. But the read_ranges is not shrunk by the segment_rowkey_range. So the pack_filter_result may contain pack does not related to the segment.Shrink the read_ranges by segment_rowkey_range before generating pack_filter_result.
Check List
Tests
Side effects
Documentation
Release note