Storages: load RSResult only once#9738
Merged
ti-chi-bot[bot] merged 12 commits intopingcap:masterfrom Dec 25, 2024
Merged
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
| } | ||
| } | ||
|
|
||
| SkippableBlockInputStreamPtr StableValueSpace::Snapshot::tryGetInputStreamWithVectorIndex( |
Contributor
There was a problem hiding this comment.
Why do we need to add this method? Seems it is the same as StableValueSpace::Snapshot::getInputStream except ann_query_info is not nullptr?
Contributor
Author
There was a problem hiding this comment.
I will continue to separate all tryGetInputStreamWithVectorIndex in the next PR, to make it more clear.
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
* Remove useless var from DMFilePackFilterResult Signed-off-by: JaySon-Huang <tshent@qq.com> * Remove shared_ptr to DMFile inside DMFilePackFilterResult Signed-off-by: JaySon-Huang <tshent@qq.com> * fix Signed-off-by: JaySon-Huang <tshent@qq.com> --------- Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
approved these changes
Dec 25, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: JaySon-Huang <tshent@qq.com>
This was referenced Jan 2, 2025
gengliqi
added a commit
to gengliqi/tiflash
that referenced
this pull request
Jan 21, 2025
Signed-off-by: gengliqi <gengliqiii@gmail.com>
12 tasks
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
Signed-off-by: Wish <breezewish@outlook.com>
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
What is changed and how it workss
Check List
Tests
Side effects
Documentation
Release note