Skip to content

update proxy of master to raftstore-proxy#9732

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
CalvinNeo:update_proxy_20241217_104930
Dec 17, 2024
Merged

update proxy of master to raftstore-proxy#9732
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
CalvinNeo:update_proxy_20241217_104930

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Dec 17, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9727 ref #4982

Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy a0aefde77e..0fdd2949c8:

Fix ps_engine.raftlog unset under default raft-engine dir (#404)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that in the disaggregated storage and compute architecture, TiFlash fails to restart after upgrade from v7.5.x

@CalvinNeo
update tiflash proxy to proxy_up/raftstore-proxy
fee60b3 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 02:52:58.285910006 +0000 UTC m=+925368.374712548: ☑️ agreed by Lloyd-Pottiger.
  • 2024-12-17 02:53:00.319711628 +0000 UTC m=+925370.408514170: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit ce295a3 into pingcap:master Dec 17, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2024

In response to a cherrypick label: failed to apply #9732 on top of branch "release-8.1":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2024

In response to a cherrypick label: failed to apply #9732 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 9, 2025
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TiFlash fails to restart under disagg arch after upgrade from v7.5.4 to v8.x "invalid configuration: Cannot find raft data set"

4 participants

@CalvinNeo @ti-chi-bot @JaySon-Huang @Lloyd-Pottiger