Skip to content

update raftstore-proxy to eliminate the forced wait 10s when profiling#9730

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
CalvinNeo:update_proxy_20241216_113859
Dec 16, 2024
Merged

update raftstore-proxy to eliminate the forced wait 10s when profiling#9730
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
CalvinNeo:update_proxy_20241216_113859

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Dec 16, 2024

What problem does this PR solve?

Issue Number: close #9726 ref #4982

Problem Summary:
update proxy to raftstore-proxy
Proxy PR: pingcap/tidb-engine-ext#403
Including:\nSubmodule contrib/tiflash-proxy 50b8d2e0fa..a0aefde77e:

Fix the problem that /debug/pprof/heap will wait 10s (#403)

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2024
@CalvinNeo CalvinNeo changed the title update proxy of master to raftstore-proxy update raftstore-proxy to eliminate the forced wait 10s when profiling Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 16, 2024
@CalvinNeo
Copy link
Member Author

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-16 06:07:05.725889348 +0000 UTC m=+850615.814691890: ☑️ agreed by JaySon-Huang.
  • 2024-12-16 06:41:25.853359155 +0000 UTC m=+852675.942161683: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot bot merged commit a44585e into pingcap:master Dec 16, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 16, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #9730 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/debug/pprof/heap may sleep for 10s

4 participants