Fix the problem that /debug/pprof/heap will wait 10s#403
Merged
CalvinNeo merged 16 commits intopingcap:raftstore-proxyfrom Dec 16, 2024
Merged
Fix the problem that /debug/pprof/heap will wait 10s#403CalvinNeo merged 16 commits intopingcap:raftstore-proxyfrom
CalvinNeo merged 16 commits intopingcap:raftstore-proxyfrom
Conversation
Co-authored-by: JaySon <tshent@qq.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
…into support-purge
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
CalvinNeo
added a commit
to CalvinNeo/tidb-engine-ext
that referenced
this pull request
Dec 17, 2024
9 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that according to
tidb-engine-ext/proxy_components/proxy_server/src/status_server/profile.rs
Line 104 in 50b8d2e
However, if we already enabled prof.active, it is no longer necessary to sleep this duration to sample.
So we will remove this interval, and dump directly. And thus requires the user to explicitly turn on prof.active.
This behavior also correspond to the behavior that after we enabled continous profiling, which TiKV already did.
The change is that we totally use TiKV's idea that make
/heapdump only theprof.dumpfile.What is changed and how it works?
Issue Number: Close #xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note