Skip to content

ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test"#9628

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_9613_
Nov 18, 2024
Merged

ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test"#9628
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_9613_

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Nov 15, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9613

Problem Summary:
Checkout the details logging in #9613 (comment)
According to the log, it took about 4 seconds to create an empty table when the CI environment is busy.

What is changed and how it works?
  • Increate the max wait time for concurrent create table to 5 seconds.
  • Refine the logging when concurrent create table happen

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2024
@JaySon-Huang JaySon-Huang changed the title unstable test "fullstack-test/mpp/rollup_tpcds.test" Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" Nov 15, 2024
@JaySon-Huang JaySon-Huang changed the title Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" Nov 15, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 15, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-15 11:30:56.492680857 +0000 UTC m=+615018.683549854: ☑️ agreed by Lloyd-Pottiger.
  • 2024-11-18 02:56:20.226104654 +0000 UTC m=+843342.416973650: ☑️ agreed by JinheLin.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 2c221d8 into pingcap:master Nov 18, 2024
@JaySon-Huang JaySon-Huang deleted the fix_9613_ branch November 18, 2024 05:22
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 18, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #9638.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 18, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #9639.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #9640.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 18, 2024
@ti-chi-bot @JaySon-Huang
ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" (#9628) (…
ea55cfe 
…#9638)

close #9613

Co-authored-by: JaySon-Huang <tshent@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 27, 2024
@ti-chi-bot @JaySon-Huang
ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" (#9628) (…
6269371 
…#9639)

close #9613

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2024
@ti-chi-bot @JaySon-Huang
ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" (#9628) (…
e98915d 
…#9640)

close #9613

Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unstable test "fullstack-test/mpp/rollup_tpcds.test"

4 participants

@JaySon-Huang @ti-chi-bot @JinheLin @Lloyd-Pottiger