Skip to content

ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" (#9628)#9640

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-9628-to-release-7.5
Nov 28, 2024
Merged

ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" (#9628)#9640
ti-chi-bot[bot] merged 4 commits intopingcap:release-7.5from
ti-chi-bot:cherry-pick-9628-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9628

What problem does this PR solve?

Issue Number: close #9613

Problem Summary:
Checkout the details logging in #9613 (comment)
According to the log, it took about 4 seconds to create an empty table when the CI environment is busy.

What is changed and how it works?


  • Increate the max wait time for concurrent create table to 5 seconds.
  • Refine the logging when concurrent create table happen

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 18, 2024
@JaySon-Huang
Copy link
Contributor

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 28, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-28 02:41:03.848350903 +0000 UTC m=+690651.468005404: ☑️ agreed by JaySon-Huang.
  • 2024-11-28 02:42:18.695627389 +0000 UTC m=+690726.315281905: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit e98915d into pingcap:release-7.5 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants