Support collation in `position` function by xzhangxian1008 · Pull Request #9601 · pingcap/tiflash

xzhangxian1008 · 2024-11-12T08:06:59Z

What problem does this PR solve?

Issue Number: close #9377
Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Support collation in `position` function

xzhangxian1008 · 2024-11-12T08:12:44Z

/cc @windtalker @yibin87

dbms/src/Functions/FunctionsString.cpp

yibin87 · 2024-11-19T03:38:39Z

Generally, use ++variable instead of variable++ unless we do need to keep the unchanged value.

dbms/src/Functions/FunctionsString.cpp

xzhangxian1008 · 2024-11-19T07:45:55Z

LibCASCIICaseSensitiveStringSearcher

Modern compiler should know if it needs to create a tmp object for variable++, so I think there is no difference between variable++ and ++variable.

dbms/src/TiDB/Collation/Collator.cpp

dbms/src/Functions/FunctionsString.cpp

dbms/src/Functions/FunctionsStringSearch.cpp

xzhangxian1008 · 2024-11-22T08:34:26Z

/cc @windtalker

windtalker

lgtm

ti-chi-bot · 2024-11-22T12:33:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [windtalker,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-11-22T12:33:36Z

[LGTM Timeline notifier]

Timeline:

2024-11-21 01:12:35.471204313 +0000 UTC m=+80543.090858829: ☑️ agreed by yibin87.
2024-11-22 12:33:35.903126019 +0000 UTC m=+207803.522780546: ☑️ agreed by windtalker.

xzhangxian1008 · 2024-11-25T03:04:33Z

/retest

xzhangxian1008 · 2024-11-25T03:04:49Z

/cherrypick release-8.1

ti-chi-bot · 2024-11-25T03:04:51Z

@xzhangxian1008: once the present PR merges, I will cherry-pick it on top of release-8.1 in the new PR and assign it to you.

Details

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

xzhangxian1008 · 2024-11-25T03:34:38Z

/retest

xzhangxian1008 · 2024-11-25T03:51:43Z

/retest

ti-chi-bot · 2024-11-25T04:59:19Z

@xzhangxian1008: new pull request created to branch release-8.1: #9669.

Details

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

xzhangxian1008 · 2024-11-26T02:04:18Z

/cherrypick release-8.5

ti-chi-bot · 2024-11-26T02:04:57Z

@xzhangxian1008: new pull request created to branch release-8.5: #9671.

Details

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #9377 Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

xzhangxian1008 added 2 commits November 12, 2024 13:21

fix

f1119d0

add tests and remove tests

b3b1757

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2024

ti-chi-bot bot requested review from windtalker and yibin87 November 12, 2024 08:12

xzhangxian1008 added 2 commits November 12, 2024 16:44

fix ci

44aa615

support collator

4eb2b23

JaySon-Huang reviewed Nov 14, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

fix

eafcfbb

windtalker reviewed Nov 18, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

xzhangxian1008 added 2 commits November 18, 2024 23:03

fix

8a0e053

tweaking

a3d3c92

yibin87 reviewed Nov 19, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

yibin87 reviewed Nov 19, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

yibin87 reviewed Nov 19, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

yibin87 reviewed Nov 19, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

windtalker reviewed Nov 19, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

address comments

c767483

xzhangxian1008 requested review from windtalker and yibin87 November 19, 2024 07:47

windtalker reviewed Nov 19, 2024

View reviewed changes

dbms/src/TiDB/Collation/Collator.cpp Outdated Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

yibin87 reviewed Nov 19, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

xzhangxian1008 added 3 commits November 19, 2024 22:22

tweaking

638a317

fix

c59265c

fix

e0d89d5

collator == nullptr

ab5a208

windtalker reviewed Nov 21, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

xzhangxian1008 added 2 commits November 21, 2024 17:38

tweaking

f5dc226

fix

969a022

xzhangxian1008 requested a review from windtalker November 21, 2024 22:09

windtalker reviewed Nov 22, 2024

View reviewed changes

dbms/src/Functions/FunctionsString.cpp Outdated Show resolved Hide resolved

dbms/src/Functions/FunctionsStringSearch.cpp Outdated Show resolved Hide resolved

remove useless codes

80bacfc

xzhangxian1008 requested a review from windtalker November 22, 2024 03:07

rename

b9bdb23

rename

19af5ed

windtalker approved these changes Nov 22, 2024

View reviewed changes

ti-chi-bot bot added the lgtm label Nov 22, 2024

ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2024

Merge branch 'master' into fix-9377

4c86a97

ti-chi-bot bot merged commit b335225 into pingcap:master Nov 25, 2024

ti-chi-bot mentioned this pull request Nov 25, 2024

Support collation in position function (#9601) #9669

Closed

12 tasks

xzhangxian1008 deleted the fix-9377 branch November 25, 2024 05:13

ti-chi-bot mentioned this pull request Nov 26, 2024

Support collation in position function (#9601) #9671

Merged

12 tasks

ti-chi-bot bot added a commit that referenced this pull request Dec 25, 2024

Support collation in position function (#9601) (#9671)

8081977

close #9377 Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

Conversation

xzhangxian1008 commented Nov 12, 2024

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

xzhangxian1008 commented Nov 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yibin87 commented Nov 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xzhangxian1008 commented Nov 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xzhangxian1008 commented Nov 22, 2024

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Nov 22, 2024

Uh oh!

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Uh oh!

xzhangxian1008 commented Nov 25, 2024

Uh oh!

xzhangxian1008 commented Nov 25, 2024

Uh oh!

ti-chi-bot commented Nov 25, 2024

Uh oh!

xzhangxian1008 commented Nov 25, 2024

Uh oh!

xzhangxian1008 commented Nov 25, 2024

Uh oh!

ti-chi-bot commented Nov 25, 2024

Uh oh!

xzhangxian1008 commented Nov 26, 2024

Uh oh!

ti-chi-bot commented Nov 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants