Skip to content

Support collation in position function (#9601)#9669

Closed
ti-chi-bot wants to merge 19 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-9601-to-release-8.1
Closed

Support collation in position function (#9601)#9669
ti-chi-bot wants to merge 19 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-9601-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 25, 2024

This is an automated cherry-pick of #9601

What problem does this PR solve?

Issue Number: close #9377
Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support collation in `position` function

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xzhangxian1008
xzhangxian1008 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
yibin87
yibin87 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xzhangxian1008, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 05:16:18.414295311 +0000 UTC m=+440766.033949826: ☑️ agreed by xzhangxian1008.
  • 2024-11-25 05:16:45.667537316 +0000 UTC m=+440793.287191833: ☑️ agreed by yibin87.

@xzhangxian1008
Copy link
Contributor

xzhangxian1008 commented Nov 25, 2024

/retest

1 similar comment
@xzhangxian1008
Copy link
Contributor

xzhangxian1008 commented Nov 26, 2024

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 26, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test b441652 link true /test pull-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xzhangxian1008
Copy link
Contributor

xzhangxian1008 commented Nov 26, 2024

/close

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 26, 2024

@xzhangxian1008: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

+1 more reviewer

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xzhangxian1008 xzhangxian1008

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @xzhangxian1008 @yibin87