Disagg: refresh expiration time of snapshot when calling getSnapshot#9570
Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom Oct 31, 2024
Merged
Disagg: refresh expiration time of snapshot when calling getSnapshot#9570ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
Conversation
Comment on lines
1220
to
-1221
| auto timeout_s = context.getSettingsRef().disagg_task_snapshot_timeout; | ||
| auto expired_at = Clock::now() + std::chrono::seconds(timeout_s); |
Contributor
There was a problem hiding this comment.
disagg_task_snapshot_timeout can be smaller now?
Contributor
Author
There was a problem hiding this comment.
This depends on how long we expect a segment to be processed in the most extreme scenario.
Under normal circumstances, this expiration time has little impact because when the delta of the last segment is fetched, the snapshot will be immediately deleted (unregisterSnapshotIfEmpty).
Lloyd-Pottiger
approved these changes
Oct 31, 2024
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/hold |
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Contributor
|
/unhold |
JaySon-Huang
approved these changes
Oct 31, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Oct 31, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
yibin87
pushed a commit
to yibin87/tiflash
that referenced
this pull request
Nov 6, 2024
…ingcap#9570) close pingcap#9567 Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com> Co-authored-by: Lloyd-Pottiger <yan1579196623@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9567
Problem Summary:
After v7.5, TiFlash use read thread pool to read segments in disagg-mode and the segment will fetch pages only when it is going to be read.
If the query is slow, there is a high probability that the snapshot will expire before the query ends.
What is changed and how it works?
Refreshing the expiration time of snapshot when calling
getSnapshot.Check List
Tests
Side effects
Documentation
Release note