Disagg: refresh expiration time of snapshot when calling getSnapshot (#9570)#9571
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1from Nov 8, 2024
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Contributor
|
/run-all-tests |
JinheLin
approved these changes
Nov 8, 2024
Lloyd-Pottiger
approved these changes
Nov 8, 2024
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9570
What problem does this PR solve?
Issue Number: close #9567
Problem Summary:
After v7.5, TiFlash use read thread pool to read segments in disagg-mode and the segment will fetch pages only when it is going to be read.
If the query is slow, there is a high probability that the snapshot will expire before the query ends.
What is changed and how it works?
Refreshing the expiration time of snapshot when calling
getSnapshot.Check List
Tests
Side effects
Documentation
Release note