ddl: Adapt with the latest vector index definition#9471
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:feature/vector-indexfrom Sep 25, 2024
Merged
ddl: Adapt with the latest vector index definition#9471ti-chi-bot[bot] merged 1 commit intopingcap:feature/vector-indexfrom
ti-chi-bot[bot] merged 1 commit intopingcap:feature/vector-indexfrom
Conversation
Lloyd-Pottiger
approved these changes
Sep 25, 2024
Contributor
|
@zimulala: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
PTAL @zanmato1984 |
breezewish
approved these changes
Sep 25, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, Lloyd-Pottiger, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
The "kind" field is removed from the tidb vector index definition
https://github.com/zimulala/tidb/blob/bce9dabc8c7712b98ca4f9cd90beca89a1d62ca8/pkg/meta/model/index.go#L36-L41
What is changed and how it works?
Removing the deadcode will make lots of test cases changes and introduce conflict when cherry-pick other PRs. This PR just do some small adaption to make things work as expected, the deadcode will be removed in later PRs
Check List
Tests
Side effects
Documentation
Release note