Skip to content

[FLASH-698] Fix TiFlash binary prompt message#326

Merged
JaySon-Huang merged 3 commits intopingcap:masterfrom
JaySon-Huang:remove-unused-binary
Nov 22, 2019
Merged

[FLASH-698] Fix TiFlash binary prompt message#326
JaySon-Huang merged 3 commits intopingcap:masterfrom
JaySon-Huang:remove-unused-binary

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Nov 20, 2019 •
edited
Loading

  • Rename "clickhouse" -> "tiflash" in prompt message
  • Add "version"
  • Remove unused components from binary
>  ./theflash
Use one of the following commands:
tiflash client [args] 
tiflash server [args] 
tiflash version [args] 

>  ./theflash version
TiFlash
Release Version:   0.1.1
Git Commit Hash:   dbe0536900f93f932b18d555a25ad36f3c0f672d
Git Commit Branch: remove-unused-binary
UTC Build Time:    2019-11-20 11:07:17

@JaySon-Huang JaySon-Huang changed the title [FLASH-698] Fix TiFlash binary help promote [FLASH-698] Fix TiFlash binary prompt message Nov 20, 2019
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 20, 2019

/rebuild

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 20, 2019

/rebuild

marsishandsome
marsishandsome approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang JaySon-Huang merged commit adb1c6b into pingcap:master Nov 22, 2019
@JaySon-Huang JaySon-Huang deleted the remove-unused-binary branch November 22, 2019 02:44
yongman pushed a commit to yongman/tiflash that referenced this pull request Jan 23, 2025
@JaySon-Huang
ddl: Adapt with the latest vector index definition (pingcap#9471) (pi…
7303cc7 
…ngcap#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

1 more reviewer

@marsishandsome marsishandsome marsishandsome approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaySon-Huang @marsishandsome