Skip to content

fix tiflash assert failure (#9456)#9458

Closed
ti-chi-bot wants to merge 2 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9456-to-release-7.1
Closed

fix tiflash assert failure (#9456)#9458
ti-chi-bot wants to merge 2 commits intopingcap:release-7.1from
ti-chi-bot:cherry-pick-9456-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 23, 2024

This is an automated cherry-pick of #9456

What problem does this PR solve?

Issue Number: ref #9430

Problem Summary:

What is changed and how it works?

Set cancellation hook after dry run of join->joinBlock so the dry run will always get a meaningfull block

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#9456
b6067e0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 23, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 23, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from windtalker, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 3726e19 link true /test pull-unit-test
pull-integration-test 3726e19 link true /test pull-integration-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@windtalker
Copy link
Contributor

windtalker commented Oct 31, 2024

close as all its change is merged into #9454

@windtalker windtalker closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@windtalker windtalker

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @windtalker