fix tiflash assert failure #9456
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Sep 23, 2024
Merged
Conversation
gengliqi
approved these changes
Sep 23, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
windtalker
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 23, 2024
ref pingcap#9430 Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
windtalker
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 23, 2024
ref pingcap#9430 Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9430
Problem Summary:
What is changed and how it works?
Set cancellation hook after dry run of
join->joinBlockso the dry run will always get a meaningfull blockCheck List
Tests
Side effects
Documentation
Release note