Fix the wrong result bug when casting string as datetime with time zone or illegal chars by solotzg · Pull Request #9255 · pingcap/tiflash

solotzg · 2024-07-25T09:39:28Z

What problem does this PR solve?

Issue Number: close #8754

Problem Summary:

What is changed and how it works?

Fix the wrong result bug when casting string as datetime with time zone or illegal chars
- func `getFracIndex` ignore time zone.
- func `parseFrac` ignore illegal suffix after microsecond format.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Fix the wrong result bug when casting string as datetime with time zone or illegal chars

solotzg · 2024-07-25T09:41:11Z

/run-all-tests

solotzg · 2024-07-25T13:33:20Z

/run-all-tests

Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>

solotzg · 2024-08-08T07:26:15Z

/run-all-tests

dbms/src/Common/MyTime.cpp

windtalker

LGTM

ti-chi-bot · 2024-08-09T02:38:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-08-09T02:38:05Z

[LGTM Timeline notifier]

Timeline:

2024-08-08 07:34:12.375809259 +0000 UTC m=+510182.242908331: ☑️ agreed by guo-shaoge.
2024-08-09 02:38:04.803775005 +0000 UTC m=+578814.670874095: ☑️ agreed by windtalker.

ti-chi-bot · 2024-08-26T04:53:50Z

In response to a cherrypick label: new pull request created to branch release-8.1: #9351.

ti-chi-bot · 2024-08-26T04:53:51Z

In response to a cherrypick label: new pull request created to branch release-7.5: #9352.

ti-chi-bot · 2024-08-26T04:53:54Z

In response to a cherrypick label: new pull request created to branch release-7.1: #9353.

ti-chi-bot · 2024-08-26T04:53:56Z

In response to a cherrypick label: new pull request created to branch release-6.5: #9354.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-08-26T04:53:58Z

In response to a cherrypick label: new pull request created to branch release-6.1: #9355.

…ne or illegal chars (#9255) (#9354) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG,Zhigao <tongzhigao@pingcap.com> Co-authored-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG, Zhigao <tongzhigao@pingcap.com>

…ne or illegal chars (#9255) (#9352) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG,Zhigao <tongzhigao@pingcap.com> Co-authored-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG, Zhigao <tongzhigao@pingcap.com>

…ne or illegal chars (#9255) (#9353) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG,Zhigao <tongzhigao@pingcap.com> Co-authored-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG, Zhigao <tongzhigao@pingcap.com>

…ne or illegal chars (#9255) (#9351) close #8754 Fix the wrong result bug when casting string as datetime with time zone or illegal chars - func `getFracIndex` ignore time zone. - func `parseFrac` ignore illegal suffix after microsecond format. Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG,Zhigao <tongzhigao@pingcap.com> Co-authored-by: Zhigao Tong <tongzhigao@pingcap.com> Co-authored-by: TONG, Zhigao <tongzhigao@pingcap.com>

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2024

pingcap deleted a comment from sre-bot Jul 25, 2024

ti-chi-bot bot added do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2024

fix issue 8754

c718a25

solotzg force-pushed the fix-8754 branch from ceb77df to c718a25 Compare July 25, 2024 13:33

pingcap deleted a comment from sre-bot Jul 25, 2024

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Jul 26, 2024

solotzg changed the title ~~test~~ Fix the wrong result bug when casting string as datetime with time zone or illegal chars Jul 26, 2024

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 26, 2024

solotzg requested review from guo-shaoge, windtalker and wshwsh12 July 26, 2024 04:50

solotzg added 2 commits August 8, 2024 15:16

more tests

a6e6694

Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>

Merge branch 'master' into fix-8754

e7a747f

guo-shaoge approved these changes Aug 8, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 8, 2024

solotzg requested a review from yibin87 August 8, 2024 09:38

windtalker reviewed Aug 9, 2024

View reviewed changes

dbms/src/Common/MyTime.cpp Show resolved Hide resolved

windtalker approved these changes Aug 9, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024

ti-chi-bot bot merged commit 7b17f5b into pingcap:master Aug 9, 2024

solotzg deleted the fix-8754 branch August 9, 2024 02:42

solotzg self-assigned this Aug 9, 2024

ti-chi-bot mentioned this pull request Aug 26, 2024

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255) #9351

Merged

12 tasks

ti-chi-bot mentioned this pull request Aug 26, 2024

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255) #9352

Merged

12 tasks

ti-chi-bot mentioned this pull request Aug 26, 2024

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255) #9353

Merged

12 tasks

ti-chi-bot mentioned this pull request Aug 26, 2024

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255) #9354

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 26, 2024

This is an automated cherry-pick of pingcap#9255

e25801e

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Aug 26, 2024

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255) #9355

Closed

12 tasks

ti-chi-bot bot removed the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Apr 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the wrong result bug when casting string as datetime with time zone or illegal chars#9255

Fix the wrong result bug when casting string as datetime with time zone or illegal chars#9255
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
solotzg:fix-8754

solotzg commented Jul 25, 2024 •

edited

Loading

Uh oh!

solotzg commented Jul 25, 2024

Uh oh!

solotzg commented Jul 25, 2024

Uh oh!

solotzg commented Aug 8, 2024

Uh oh!

Uh oh!

windtalker left a comment

Uh oh!

ti-chi-bot bot commented Aug 9, 2024

Uh oh!

ti-chi-bot bot commented Aug 9, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

solotzg commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

solotzg commented Jul 25, 2024

Uh oh!

solotzg commented Jul 25, 2024

Uh oh!

solotzg commented Aug 8, 2024

Uh oh!

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Aug 9, 2024

Uh oh!

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

ti-chi-bot commented Aug 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

solotzg commented Jul 25, 2024 •

edited

Loading