Skip to content

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255)#9354

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-9255-to-release-6.5
Sep 2, 2024
Merged

Fix the wrong result bug when casting string as datetime with time zone or illegal chars (#9255)#9354
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.5from
ti-chi-bot:cherry-pick-9255-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 26, 2024

This is an automated cherry-pick of #9255

What problem does this PR solve?

Issue Number: close #8754

Problem Summary:

What is changed and how it works?

Fix the wrong result bug when casting string as datetime with time zone or illegal chars
- func `getFracIndex` ignore time zone.
- func `parseFrac` ignore illegal suffix after microsecond format.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the wrong result bug when casting string as datetime with time zone or illegal chars

solotzg added 2 commits August 26, 2024 04:53
@solotzg @ti-chi-bot
fix issue 8754
b23dd83
@solotzg @ti-chi-bot
more tests
c0fd99e 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 26, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
@solotzg
Copy link
Contributor

solotzg commented Sep 2, 2024

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

@solotzg: It seems you want to approve this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 2, 2024
windtalker
windtalker approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 2, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: solotzg, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 2, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 02:33:29.425383914 +0000 UTC m=+238933.943436833: ☑️ agreed by solotzg.
  • 2024-09-02 02:35:57.013881369 +0000 UTC m=+239081.531934294: ☑️ agreed by windtalker.

@solotzg
Copy link
Contributor

solotzg commented Sep 2, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 658075d into pingcap:release-6.5 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@solotzg solotzg solotzg approved these changes

Assignees

@solotzg solotzg

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @solotzg @windtalker