Skip to content

ddl: Fix logging cause by non-dropped table#8955

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
JaySon-Huang:fix_gc
Apr 18, 2024
Merged

ddl: Fix logging cause by non-dropped table#8955
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
JaySon-Huang:fix_gc

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Apr 17, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8911

Problem Summary:

After #8910, if some tables are not able to be dropped, SchemaSyncService::gcImpl will run again with the same gc_safepoint.
But in this path, SchemaSyncService::gcImpl always return true. So if there are some tables can not be dropped for some bugs, then this function will run again and again and print lots of loggings.

What is changed and how it works?

if succeeded == false, then let SchemaSyncService::gcImpl run again after ddl_sync_interval_seconds

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 17, 2024
@JaySon-Huang JaySon-Huang marked this pull request as draft April 17, 2024 10:46
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2024
@JaySon-Huang JaySon-Huang marked this pull request as ready for review April 17, 2024 11:05
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Apr 17, 2024
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Apr 17, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 17, 2024
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Apr 17, 2024

/run-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 13:37:55.66591487 +0000 UTC m=+431694.776961326: ☑️ agreed by Lloyd-Pottiger.
  • 2024-04-17 14:54:25.560938127 +0000 UTC m=+436284.671984577: ☑️ agreed by JinheLin.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Apr 18, 2024

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit d145b00 into pingcap:master Apr 18, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #8958.

@JaySon-Huang JaySon-Huang deleted the fix_gc branch April 18, 2024 02:16
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 18, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #8961.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 18, 2024
@ti-chi-bot
ddl: Fix logging cause by non-dropped table (#8955) (#8961)
89deab9 
close #8911
ti-chi-bot bot pushed a commit that referenced this pull request Apr 18, 2024
@ti-chi-bot
ddl: Fix logging cause by non-dropped table (#8955) (#8958)
9002cc3 
close #8911
@JaySon-Huang JaySon-Huang mentioned this pull request Apr 20, 2024
Merged
12 tasks
This was referenced Apr 22, 2024
Merged
Merged
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 20, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Physically dropping table is slow sometime

4 participants

@JaySon-Huang @ti-chi-bot @JinheLin @Lloyd-Pottiger