ddl: Fix logging cause by non-dropped table (#8955)#8961
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1from Apr 18, 2024
Merged
ddl: Fix logging cause by non-dropped table (#8955)#8961ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1from
ti-chi-bot[bot] merged 3 commits intopingcap:release-8.1from
Conversation
12 tasks
Contributor
|
/run-all-tests |
JaySon-Huang
approved these changes
Apr 18, 2024
JinheLin
approved these changes
Apr 18, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8955
What problem does this PR solve?
Issue Number: close #8911
Problem Summary:
After #8910, if some tables are not able to be dropped,
SchemaSyncService::gcImplwill run again with the same gc_safepoint.But in this path,
SchemaSyncService::gcImplalways return true. So if there are some tables can not be dropped for some bugs, then this function will run again and again and print lots of loggings.What is changed and how it works?
if
succeeded == false, then letSchemaSyncService::gcImplrun again afterddl_sync_interval_secondsCheck List
Tests
Side effects
Documentation
Release note