Skip to content

Fix RegionEpoch Error and CheckWaitIndex takes too long#5498

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
CalvinNeo:fmaster
Jul 29, 2022
Merged

Fix RegionEpoch Error and CheckWaitIndex takes too long#5498
ti-chi-bot merged 9 commits intopingcap:masterfrom
CalvinNeo:fmaster

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 29, 2022

What problem does this PR solve?

Issue Number: close #5458

Problem Summary:

We need to update apply index in pre_exec when handing CompactLog

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo added 2 commits July 29, 2022 08:17
@CalvinNeo
f
b83f19e 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
cddd2e9 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
CalvinNeo added 4 commits July 29, 2022 09:17
@CalvinNeo
f
f68a751 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
ffcd8e8 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
1134fbb 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
d0c225e 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 29, 2022

/run-all-tests

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 29, 2022

/cc @breezewish @flowbehappy

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 29, 2022

/run-unit-test

@CalvinNeo
f
8b53489 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022
@CalvinNeo
f
e3e2562 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 29, 2022

/run-all-tests

Lloyd-Pottiger
Lloyd-Pottiger approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 29, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       409                81    80.20%          43                 3    93.02%         680                90    86.76%         220                80    63.64%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp           310                43    86.13%          28                 2    92.86%        1308                33    97.48%          28                23    17.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             907               245    72.99%         122                36    70.49%        2390               411    82.80%         316               134    57.59%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18868      9439             49.97%    215031  95383        55.64%

full coverage report (for internal network access only)

@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 29, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e3e2562

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 29, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 29, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       409                81    80.20%          43                 3    93.02%         680                90    86.76%         220                80    63.64%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp           310                43    86.13%          28                 2    92.86%        1308                33    97.48%          28                23    17.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             907               245    72.99%         122                36    70.49%        2390               411    82.80%         316               134    57.59%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18861      9429             50.01%    215003  95274        55.69%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit f6f7b0f into pingcap:master Jul 29, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 29, 2022

In response to a cherrypick label: new pull request created: #5507.

ti-chi-bot added a commit that referenced this pull request Jul 29, 2022
@ti-chi-bot
Fix RegionEpoch Error and CheckWaitIndex takes too long (#5498) (#5507)
1a9fadf 
close #5458
@CalvinNeo CalvinNeo mentioned this pull request Aug 3, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'Region epoch not match' happened after TiFlash restart

6 participants

@CalvinNeo @ti-chi-bot @sre-bot @flowbehappy @breezewish @Lloyd-Pottiger