Skip to content

Fix RegionEpoch Error and CheckWaitIndex takes too long (#5498)#5507

Merged
ti-chi-bot merged 8 commits intopingcap:release-6.2from
ti-chi-bot:cherry-pick-5498-to-release-6.2
Jul 29, 2022
Merged

Fix RegionEpoch Error and CheckWaitIndex takes too long (#5498)#5507
ti-chi-bot merged 8 commits intopingcap:release-6.2from
ti-chi-bot:cherry-pick-5498-to-release-6.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 29, 2022

This is an automated cherry-pick of #5498

What problem does this PR solve?

Issue Number: close #5458

Problem Summary:

We need to update apply index in pre_exec when handing CompactLog

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo added 8 commits July 29, 2022 07:19
@CalvinNeo @ti-chi-bot
f
300881f 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
e77f633 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
9744ebe 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
8efb31c 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
99f7977 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
4b7f33d 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
34e3fb4 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo @ti-chi-bot
f
b12e809 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jul 29, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.2 labels Jul 29, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2022
@flowbehappy flowbehappy self-requested a review July 29, 2022 07:55
@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 29, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 29, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 29, 2022

@flowbehappy: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 29, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       409                81    80.20%          43                 3    93.02%         680                90    86.76%         220                80    63.64%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp          3791               752    80.16%          28                 2    92.86%        1308                31    97.63%        1126               597    46.98%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4388               954    78.26%         122                36    70.49%        2390               409    82.89%        1414               708    49.93%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      9447             49.70%    213997  95414        55.41%

full coverage report (for internal network access only)

@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 29, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 29, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 29, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b12e809

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 29, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       409                81    80.20%          43                 3    93.02%         680                90    86.76%         220                80    63.64%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp          3791               752    80.16%          28                 2    92.86%        1308                31    97.63%        1126               597    46.98%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4388               954    78.26%         122                36    70.49%        2390               409    82.89%        1414               708    49.93%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      9449             49.69%    213997  95447        55.40%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 1a9fadf into pingcap:release-6.2 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

@CalvinNeo CalvinNeo

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @flowbehappy @sre-bot @Lloyd-Pottiger @CalvinNeo @VelocityLight