Skip to content

bugfix for core of GRPCCompQueue when tiflash shutdown#5483

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
bestwoody:bugfix_5480
Jul 27, 2022
Merged

bugfix for core of GRPCCompQueue when tiflash shutdown#5483
ti-chi-bot merged 2 commits intopingcap:masterfrom
bestwoody:bugfix_5480

Conversation

@bestwoody
Copy link
Contributor

@bestwoody bestwoody commented Jul 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5480

Problem Summary:

What is changed and how it works?

notify GRPCCompQueue the shotdown event when TiFlash is shutdown.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2022
windtalker
windtalker approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
CalvinNeo
CalvinNeo approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
@CalvinNeo
Copy link
Member

CalvinNeo commented Jul 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 25177f0

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 27, 2022

Coverage for changed files

Filename                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
GRPCCompletionQueuePool.cpp          19                19     0.00%           4                 4     0.00%          34                34     0.00%           8                 8     0.00%
GRPCCompletionQueuePool.h             1                 1     0.00%           1                 1     0.00%           3                 3     0.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                20                20     0.00%           5                 5     0.00%          37                37     0.00%           8                 8     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18835      9435             49.91%    214758  95357        55.60%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 245e2fb into pingcap:master Jul 27, 2022
@bestwoody bestwoody deleted the bugfix_5480 branch July 27, 2022 13:59
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022

In response to a cherrypick label: new pull request created: #5484.

yibin87
yibin87 reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ti-chi-bot added a commit that referenced this pull request Jul 28, 2022
@ti-chi-bot
bugfix for core of GRPCCompQueue when tiflash shutdown (#5483) (#5484)
f8abc3b 
close #5480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 left review comments

@windtalker windtalker windtalker approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TiFlash Coredump about GRPC when restart

6 participants

@bestwoody @ti-chi-bot @CalvinNeo @sre-bot @windtalker @yibin87