Skip to content

bugfix for core of GRPCCompQueue when tiflash shutdown (#5483)#5484

Merged
ti-chi-bot merged 2 commits intopingcap:release-6.2from
ti-chi-bot:cherry-pick-5483-to-release-6.2
Jul 28, 2022
Merged

bugfix for core of GRPCCompQueue when tiflash shutdown (#5483)#5484
ti-chi-bot merged 2 commits intopingcap:release-6.2from
ti-chi-bot:cherry-pick-5483-to-release-6.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 27, 2022

This is an automated cherry-pick of #5483

What problem does this PR solve?

Issue Number: close #5480

Problem Summary:

What is changed and how it works?

notify GRPCCompQueue the shotdown event when TiFlash is shutdown.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.2 do-not-merge/cherry-pick-not-approved labels Jul 27, 2022
@bestwoody bestwoody self-requested a review July 27, 2022 14:00
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@bestwoody bestwoody requested review from windtalker and yibin87 July 27, 2022 14:01
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 28, 2022
zanmato1984
zanmato1984 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@zanmato1984
Copy link
Contributor

zanmato1984 commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6911d14

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 28, 2022

Coverage for changed files

Filename                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
GRPCCompletionQueuePool.cpp          19                19     0.00%           4                 4     0.00%          34                34     0.00%           8                 8     0.00%
GRPCCompletionQueuePool.h             1                 1     0.00%           1                 1     0.00%           3                 3     0.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                20                20     0.00%           5                 5     0.00%          37                37     0.00%           8                 8     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18781      9451             49.68%    213993  95507        55.37%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit f8abc3b into pingcap:release-6.2 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

@yibin87 yibin87 Awaiting requested review from yibin87

+1 more reviewer

@bestwoody bestwoody bestwoody approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bestwoody bestwoody

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @zanmato1984 @sre-bot @bestwoody @VelocityLight