Skip to content

Design doc: DeltaTree Read Thread Pool and Data Sharing#5478

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
JinheLin:add-design-doc-of-read-thread
Jul 28, 2022
Merged

Design doc: DeltaTree Read Thread Pool and Data Sharing#5478
ti-chi-bot merged 7 commits intopingcap:masterfrom
JinheLin:add-design-doc-of-read-thread

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jul 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5488

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 27, 2022
flowbehappy
flowbehappy reviewed Jul 28, 2022
View reviewed changes
@flowbehappy flowbehappy self-requested a review July 28, 2022 02:59
flowbehappy
flowbehappy approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@JinheLin @flowbehappy
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
15f2cde 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Lloyd-Pottiger
Lloyd-Pottiger reviewed Jul 28, 2022
View reviewed changes
JinheLin and others added 3 commits July 28, 2022 11:44
@JinheLin @Lloyd-Pottiger
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
e092739 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@JinheLin @Lloyd-Pottiger
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
a35e936 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@JinheLin @Lloyd-Pottiger
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
59af8ec 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@JinheLin
Copy link
Contributor Author

JinheLin commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 59af8ec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 28, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18868      9436             49.99%    215027  95345        55.66%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit bcb029e into pingcap:master Jul 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022

In response to a cherrypick label: new pull request created: #5490.

ti-chi-bot added a commit that referenced this pull request Jul 28, 2022
@ti-chi-bot
Design doc: DeltaTree Read Thread Pool and Data Sharing (#5478) (#5490)
dd29d25 
ref #5488
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 28, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18868      9439             49.97%    215027  95338        55.66%

full coverage report (for internal network access only)

@JinheLin JinheLin deleted the add-design-doc-of-read-thread branch August 4, 2022 07:40
@JinheLin JinheLin mentioned this pull request Aug 29, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@hehechen hehechen Awaiting requested review from hehechen

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pick design doc of Read Thread Pool and Data Sharing to 6.2

5 participants

@JinheLin @ti-chi-bot @sre-bot @flowbehappy @Lloyd-Pottiger