Skip to content

Design doc: DeltaTree Read Thread Pool and Data Sharing (#5478)#5490

Merged
ti-chi-bot merged 6 commits intopingcap:release-6.2from
ti-chi-bot:cherry-pick-5478-to-release-6.2
Jul 28, 2022
Merged

Design doc: DeltaTree Read Thread Pool and Data Sharing (#5478)#5490
ti-chi-bot merged 6 commits intopingcap:release-6.2from
ti-chi-bot:cherry-pick-5478-to-release-6.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 28, 2022

This is an automated cherry-pick of #5478

What problem does this PR solve?

Issue Number: ref #5488

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

JinheLin and others added 6 commits July 28, 2022 04:27
@JinheLin @ti-chi-bot
add design doc
cc87760
@JinheLin @ti-chi-bot
update
adc38c9
@JinheLin @flowbehappy @ti-chi-bot
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
7d086e8 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@JinheLin @Lloyd-Pottiger @ti-chi-bot
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
a224777 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@JinheLin @Lloyd-Pottiger @ti-chi-bot
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
3a4043c 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@JinheLin @Lloyd-Pottiger @ti-chi-bot
Update docs/design/2022-07-25-read-thread-pool-and-data-sharing.md
86a2fd3 
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JinheLin
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.2 labels Jul 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 28, 2022
@JinheLin
Copy link
Contributor

JinheLin commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 86a2fd3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 28, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18780      9446             49.70%    213987  95467        55.39%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit dd29d25 into pingcap:release-6.2 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

@JinheLin JinheLin

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @JinheLin @sre-bot @Lloyd-Pottiger @VelocityLight