Skip to content

Fix unstable drop table unit test#5059

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
lidezhu:fix-drop-table-unit-test
Jun 3, 2022
Merged

Fix unstable drop table unit test#5059
ti-chi-bot merged 5 commits intopingcap:masterfrom
lidezhu:fix-drop-table-unit-test

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Jun 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5060

Problem Summary: To make the segments in the unit test split more easily, we change the dt related params in settings.
But we just change the settings in the local context, and in the global context the settings is unchanged.
When processing write request, DeltaMergeStore calls checkSegment with the local context we passed. So it splits as we expected.
But we do several DeltaMergeStore initialization in the test, and in the initialization process, DeltaMergeStore calls checkSegment with the global_context, and try to merge the segments which make the test not stable

What is changed and how it works?

Make the settings in local context and global_context consistent.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 2, 2022
@lidezhu lidezhu self-assigned this Jun 2, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jun 2, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 2, 2022

Coverage for changed files

Filename                                                                                                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/tests/gtest_dm_storage_delta_merge.cpp        1773               351    80.20%          18                 0   100.00%         741                12    98.38%         564               267    52.66%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                                 1773               351    80.20%          18                 0   100.00%         741                12    98.38%         564               267    52.66%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9734             46.76%    204990  97609        52.38%

full coverage report (for internal network access only)

@lidezhu lidezhu added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 3, 2022
JaySon-Huang
JaySon-Huang approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jun 3, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2022

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b745aa2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 3, 2022

Coverage for changed files

Filename                                                                                                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/tests/gtest_dm_storage_delta_merge.cpp        1773               351    80.20%          18                 0   100.00%         740                12    98.38%         564               267    52.66%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                                 1773               351    80.20%          18                 0   100.00%         740                12    98.38%         564               267    52.66%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9732             46.77%    205087  97594        52.41%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit a66c082 into pingcap:master Jun 3, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2022

In response to a cherrypick label: new pull request created: #5072.

lidezhu added a commit that referenced this pull request Jun 21, 2022
@ti-chi-bot @lidezhu
Fix unstable drop table unit test (#5059) (#5072)
68deedb 
* Fix unstable drop table unit test

* simplify settings change

* Update gtest_dm_storage_delta_merge.cpp

Co-authored-by: lidezhu <lidezhu@pingcap.com>
Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

@windtalker windtalker Awaiting requested review from windtalker

Assignees

@lidezhu lidezhu

Labels

needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop table unit test is not stable

5 participants

@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang @Lloyd-Pottiger