Skip to content

Fix unstable drop table unit test (#5059)#5072

Merged
lidezhu merged 4 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-5059-to-release-6.1
Jun 21, 2022
Merged

Fix unstable drop table unit test (#5059)#5072
lidezhu merged 4 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-5059-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 3, 2022

This is an automated cherry-pick of #5059

What problem does this PR solve?

Issue Number: close #5060

Problem Summary: To make the segments in the unit test split more easily, we change the dt related params in settings.
But we just change the settings in the local context, and in the global context the settings is unchanged.
When processing write request, DeltaMergeStore calls checkSegment with the local context we passed. So it splits as we expected.
But we do several DeltaMergeStore initialization in the test, and in the initialization process, DeltaMergeStore calls checkSegment with the global_context, and try to merge the segments which make the test not stable

What is changed and how it works?

Make the settings in local context and global_context consistent.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jun 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2022
@lidezhu
Copy link
Contributor

lidezhu commented Jun 21, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 21, 2022

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 99a2d90

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@lidezhu
Copy link
Contributor

lidezhu commented Jun 21, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 21, 2022

Coverage for changed files

Filename                                                                                                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/tests/gtest_dm_storage_delta_merge.cpp        1738               345    80.15%          18                 0   100.00%         734                12    98.37%         552               261    52.72%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                                 1738               345    80.15%          18                 0   100.00%         734                12    98.37%         552               261    52.72%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18239      9788             46.33%    204369  98036        52.03%

full coverage report (for internal network access only)

@lidezhu lidezhu merged commit 68deedb into pingcap:release-6.1 Jun 21, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@lidezhu lidezhu lidezhu approved these changes

Assignees

@lidezhu lidezhu

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

v6.1.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @lidezhu @sre-bot @JaySon-Huang @VelocityLight @jayl1e