PageStorage: Report the file usage of BlobStore by JaySon-Huang · Pull Request #4999 · pingcap/tiflash

JaySon-Huang · 2022-05-25T11:33:41Z

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: close #4922

Problem Summary: Report the file size, valid data size, file num of all PageStorage instances in a TiFlash node

What is changed and how it works?

Report the file size, valid data size, file num of all PageStorage instances in AsynchronousMetrics::update
Show the file size, valid data size and file num in Grafana
Move "PageStorage Blob Status" into "StoragePool"

Check List

Tests

Unit test
Integration test
No code
Manual test (add detailed scripts or steps below)
- Deploy and run sysbench oltp_update_index workload
- http://172.16.5.81:21510/d/5xovuGr7k/verify-tiflash-summary?orgId=1&from=1653629400000&to=1653632700000

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-05-25T11:33:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

flowbehappy
jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: JaySon-Huang <tshent@qq.com>

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

dbms/src/Interpreters/AsynchronousMetrics.cpp

jiaqizho · 2022-05-27T08:18:57Z

dbms/src/Storages/Page/V3/BlobStore.cpp

+            else
+            {
+                // Else the stat may being updated, acquire a lock to avoid data race.
+                auto lock = stat->lock();


Can this lock be removed? we mat not need an exact value.

Running under TSan may complain about that

We want a consistent value that total_size > valid size. Without lock, we may meet total_size < valid size, which is confusing

The frequency of calling getFileUsageStatistics is very low, call it only once every 30s

So I would rather keep the lock here

dbms/src/Storages/Page/V3/BlobStore.cpp

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

jiaqizho

LGTM

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2022-05-27T09:55:39Z

/merge

ti-chi-bot · 2022-05-27T09:55:40Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-27T09:55:41Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: a0dcfc7

ti-chi-bot · 2022-05-27T11:24:57Z

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

JaySon-Huang · 2022-05-27T11:46:47Z

/run-unit-test

sre-bot · 2022-05-27T11:58:28Z

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.h                 11                 1    90.91%          11                 1    90.91%          31                 9    70.97%           0                 0         -
Page/PageStorage.cpp                    149                38    74.50%          50                10    80.00%         410               112    72.68%         108                30    72.22%
Page/PageStorage.h                       20                 3    85.00%          20                 3    85.00%          88                 7    92.05%           0                 0         -
Page/Snapshot.h                           6                 0   100.00%           6                 0   100.00%          12                 0   100.00%           0                 0         -
Page/V3/BlobStore.cpp                   585               155    73.50%          54                 2    96.30%        1169               257    78.02%         370               134    63.78%
Page/V3/BlobStore.h                      12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/PageStorageImpl.cpp             135                32    76.30%          25                 6    76.00%         296                52    82.43%          72                22    69.44%
Page/V3/PageStorageImpl.h                 8                 2    75.00%           8                 2    75.00%          22                 2    90.91%           0                 0         -
Transaction/KVStore.h                     6                 4    33.33%           6                 4    33.33%           8                 6    25.00%           0                 0         -
Transaction/RegionPersister.cpp         160                80    50.00%          16                 3    81.25%         300               121    59.67%          84                46    45.24%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1092               317    70.97%         206                33    83.98%        2386               589    75.31%         636               232    63.52%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18285      9793             46.44%    204852  98176        52.07%

full coverage report (for internal network access only)

ti-chi-bot · 2022-05-27T11:59:25Z

In response to a cherrypick label: new pull request created: #5027.

close #4922

ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2022

JaySon-Huang force-pushed the add_blob_usage branch from 3f22da2 to 47c1e83 Compare May 27, 2022 05:20

JaySon-Huang and others added 3 commits May 27, 2022 14:18

Report the file usage of BlobStore

5a54258

Signed-off-by: JaySon-Huang <tshent@qq.com>

Remove verbose tracing

6620394

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Show the file usage in grafana

c0561ac

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang force-pushed the add_blob_usage branch from 47c1e83 to c0561ac Compare May 27, 2022 06:25

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2022

JaySon-Huang changed the title ~~[WIP]PageStorage: Report the file usage of BlobStore~~ PageStorage: Report the file usage of BlobStore May 27, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2022

JaySon-Huang added 4 commits May 27, 2022 14:49

Refine code

8f780d8

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

update grafana

4db7bb5

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

fix

fce4916

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Add comment

40688ec

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

flowbehappy self-requested a review May 27, 2022 08:18

flowbehappy approved these changes May 27, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022

jiaqizho reviewed May 27, 2022

View reviewed changes

Address comment

9b43d99

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 27, 2022

jiaqizho approved these changes May 27, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022

JaySon-Huang added 2 commits May 27, 2022 17:53

Fix lint

dcd875f

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Merge branch 'master' into add_blob_usage

a0dcfc7

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022

Merge branch 'master' into add_blob_usage

028e0ef

ti-chi-bot merged commit d1ecebd into pingcap:master May 27, 2022

ti-chi-bot mentioned this pull request May 27, 2022

PageStorage: Report the file usage of BlobStore (#4999) #5027

Merged

12 tasks

JaySon-Huang deleted the add_blob_usage branch May 27, 2022 12:00

ti-chi-bot added a commit that referenced this pull request May 27, 2022

PageStorage: Report the file usage of BlobStore (#4999) (#5027)

fff77b4

close #4922

Conversation

JaySon-Huang commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jiaqizho May 27, 2022

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang May 27, 2022

Choose a reason for hiding this comment

Uh oh!

jiaqizho May 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jiaqizho left a comment

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang commented May 27, 2022

Uh oh!

ti-chi-bot commented May 27, 2022

Uh oh!

ti-chi-bot commented May 27, 2022

Uh oh!

ti-chi-bot commented May 27, 2022

Uh oh!

JaySon-Huang commented May 27, 2022

Uh oh!

sre-bot commented May 27, 2022

Coverage for changed files

Coverage summary

Uh oh!

ti-chi-bot commented May 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JaySon-Huang commented May 25, 2022 •

edited

Loading

ti-chi-bot commented May 25, 2022 •

edited

Loading