Skip to content

PageStorage: Report the file usage of BlobStore (#4999)#5027

Merged
ti-chi-bot merged 10 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-4999-to-release-6.1
May 27, 2022
Merged

PageStorage: Report the file usage of BlobStore (#4999)#5027
ti-chi-bot merged 10 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-4999-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 27, 2022

This is an automated cherry-pick of #4999

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: close #4922

Problem Summary: Report the file size, valid data size, file num of all PageStorage instances in a TiFlash node

What is changed and how it works?

  • Report the file size, valid data size, file num of all PageStorage instances in AsynchronousMetrics::update
  • Show the file size, valid data size and file num in Grafana
  • Move "PageStorage Blob Status" into "StoragePool"

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

JaySon-Huang and others added 9 commits May 27, 2022 11:59
@JaySon-Huang @ti-chi-bot
Report the file usage of BlobStore
80484b2 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang @ti-chi-bot
Remove verbose tracing
8316c38 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
Show the file usage in grafana
5130dc6 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
Refine code
eb00afc 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
update grafana
55164c5 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
fix
06c9261 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
Add comment
5d82e08 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
Address comment
aa22765 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang @ti-chi-bot
Fix lint
aed2e46 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 27, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 27, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels May 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 27, 2022
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@JaySon-Huang: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: aed2e46

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.h                 11                 1    90.91%          11                 1    90.91%          31                 9    70.97%           0                 0         -
Page/PageStorage.cpp                    149                41    72.48%          50                11    78.00%         410               122    70.24%         108                32    70.37%
Page/PageStorage.h                       20                 2    90.00%          20                 2    90.00%          88                 6    93.18%           0                 0         -
Page/Snapshot.h                           6                 0   100.00%           6                 0   100.00%          12                 0   100.00%           0                 0         -
Page/V3/BlobStore.cpp                   571               173    69.70%          54                 2    96.30%        1157               270    76.66%         362               137    62.15%
Page/V3/BlobStore.h                      12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/PageStorageImpl.cpp             135                38    71.85%          25                 8    68.00%         296                68    77.03%          72                27    62.50%
Page/V3/PageStorageImpl.h                 8                 2    75.00%           8                 2    75.00%          22                 2    90.91%           0                 0         -
Transaction/KVStore.h                     6                 4    33.33%           6                 4    33.33%           8                 6    25.00%           0                 0         -
Transaction/RegionPersister.cpp         160                81    49.38%          16                 3    81.25%         300               133    55.67%          84                48    42.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1078               344    68.09%         206                35    83.01%        2374               639    73.08%         628               244    61.15%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18239      9791             46.32%    204240  98053        51.99%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.h                 11                 1    90.91%          11                 1    90.91%          31                 9    70.97%           0                 0         -
Page/PageStorage.cpp                    149                41    72.48%          50                11    78.00%         410               122    70.24%         108                32    70.37%
Page/PageStorage.h                       20                 2    90.00%          20                 2    90.00%          88                 6    93.18%           0                 0         -
Page/Snapshot.h                           6                 0   100.00%           6                 0   100.00%          12                 0   100.00%           0                 0         -
Page/V3/BlobStore.cpp                   571               173    69.70%          54                 2    96.30%        1157               270    76.66%         362               137    62.15%
Page/V3/BlobStore.h                      12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/PageStorageImpl.cpp             135                38    71.85%          25                 8    68.00%         296                68    77.03%          72                27    62.50%
Page/V3/PageStorageImpl.h                 8                 2    75.00%           8                 2    75.00%          22                 2    90.91%           0                 0         -
Transaction/KVStore.h                     6                 4    33.33%           6                 4    33.33%           8                 6    25.00%           0                 0         -
Transaction/RegionPersister.cpp         160                81    49.38%          16                 3    81.25%         300               133    55.67%          84                48    42.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1078               344    68.09%         206                35    83.01%        2374               639    73.08%         628               244    61.15%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18239      9791             46.32%    204240  98044        52.00%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.h                 11                 1    90.91%          11                 1    90.91%          31                 9    70.97%           0                 0         -
Page/PageStorage.cpp                    149                41    72.48%          50                11    78.00%         410               122    70.24%         108                32    70.37%
Page/PageStorage.h                       20                 2    90.00%          20                 2    90.00%          88                 6    93.18%           0                 0         -
Page/Snapshot.h                           6                 0   100.00%           6                 0   100.00%          12                 0   100.00%           0                 0         -
Page/V3/BlobStore.cpp                   571               173    69.70%          54                 2    96.30%        1157               270    76.66%         362               137    62.15%
Page/V3/BlobStore.h                      12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/PageStorageImpl.cpp             135                38    71.85%          25                 8    68.00%         296                68    77.03%          72                27    62.50%
Page/V3/PageStorageImpl.h                 8                 2    75.00%           8                 2    75.00%          22                 2    90.91%           0                 0         -
Transaction/KVStore.h                     6                 4    33.33%           6                 4    33.33%           8                 6    25.00%           0                 0         -
Transaction/RegionPersister.cpp         160                81    49.38%          16                 3    81.25%         300               133    55.67%          84                48    42.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1078               344    68.09%         206                35    83.01%        2374               639    73.08%         628               244    61.15%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18239      9791             46.32%    204240  98061        51.99%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 27, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.h                 11                 1    90.91%          11                 1    90.91%          31                 9    70.97%           0                 0         -
Page/PageStorage.cpp                    149                41    72.48%          50                11    78.00%         410               122    70.24%         108                32    70.37%
Page/PageStorage.h                       20                 2    90.00%          20                 2    90.00%          88                 6    93.18%           0                 0         -
Page/Snapshot.h                           6                 0   100.00%           6                 0   100.00%          12                 0   100.00%           0                 0         -
Page/V3/BlobStore.cpp                   571               173    69.70%          54                 2    96.30%        1157               270    76.66%         362               137    62.15%
Page/V3/BlobStore.h                      12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/PageStorageImpl.cpp             135                38    71.85%          25                 8    68.00%         296                68    77.03%          72                27    62.50%
Page/V3/PageStorageImpl.h                 8                 2    75.00%           8                 2    75.00%          22                 2    90.91%           0                 0         -
Transaction/KVStore.h                     6                 4    33.33%           6                 4    33.33%           8                 6    25.00%           0                 0         -
Transaction/RegionPersister.cpp         160                81    49.38%          16                 3    81.25%         300               133    55.67%          84                48    42.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1078               344    68.09%         206                35    83.01%        2374               639    73.08%         628               244    61.15%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18239      9791             46.32%    204249  98070        51.99%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit fff77b4 into pingcap:release-6.1 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

+1 more reviewer

@jiaqizho jiaqizho jiaqizho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JaySon-Huang JaySon-Huang

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @JaySon-Huang @sre-bot @jiaqizho @VelocityLight