Skip to content

*: ensure all futures finished in waitTasks#4199

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
fuzhe1989:fuzhe/waitTasks
Mar 8, 2022
Merged

*: ensure all futures finished in waitTasks#4199
ti-chi-bot merged 2 commits intopingcap:masterfrom
fuzhe1989:fuzhe/waitTasks

Conversation

@fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Mar 8, 2022

Signed-off-by: fuzhe1989 fuzhe@pingcap.com

What problem does this PR solve?

Issue Number: close #4198

Problem Summary: as related issue said

What is changed and how it works?

waitTasks will catch the first exception throwed by futures, wait for all futures done, then rethrow the catched exception (if has).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

ensure all futures finished in waitTasks
228cff3 
Signed-off-by: fuzhe1989 <fuzhe@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2022
windtalker
windtalker approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2022
bestwoody
bestwoody approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@bestwoody bestwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2022
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Mar 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 228cff3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 8, 2022

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Common/ThreadManager.cpp          30                30     0.00%          15                15     0.00%          67                67     0.00%          12                12     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  30                30     0.00%          15                15     0.00%          67                67     0.00%          12                12     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16777      9447             43.69%    188908  95727        49.33%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 077b162 into pingcap:master Mar 8, 2022
@JaySon-Huang JaySon-Huang deleted the fuzhe/waitTasks branch March 9, 2022 05:00
@fuzhe1989 fuzhe1989 added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 10, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022

In response to a cherrypick label: new pull request created: #4216.

ti-chi-bot added a commit that referenced this pull request Apr 24, 2022
@ti-chi-bot
*: ensure all futures finished in waitTasks (#4199) (#4216)
a6628f7 
close #4198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@bestwoody bestwoody bestwoody approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

waitTasks doesn't wait for all futures finished.

5 participants

@fuzhe1989 @ti-chi-bot @sre-bot @windtalker @bestwoody