Skip to content

*: ensure all futures finished in waitTasks (#4199)#4216

Merged
ti-chi-bot merged 2 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-4199-to-release-5.4
Apr 24, 2022
Merged

*: ensure all futures finished in waitTasks (#4199)#4216
ti-chi-bot merged 2 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-4199-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 10, 2022

This is an automated cherry-pick of #4199

Signed-off-by: fuzhe1989 fuzhe@pingcap.com

What problem does this PR solve?

Issue Number: close #4198

Problem Summary: as related issue said

What is changed and how it works?

waitTasks will catch the first exception throwed by futures, wait for all futures done, then rethrow the catched exception (if has).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
ensure all futures finished in waitTasks
3f7c4aa 
Signed-off-by: fuzhe1989 <fuzhe@pingcap.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Mar 10, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 10, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@JaySon-Huang JaySon-Huang added this to the v5.4.1 milestone Apr 21, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 22, 2022
windtalker
windtalker approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 24, 2022
@windtalker
Copy link
Contributor

windtalker commented Apr 24, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 24, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 24, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3f7c4aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 24, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 24, 2022

lines: 43.3% (49812 out of 115126)
branches: 6.4% (81417 out of 1263890)

@ti-chi-bot ti-chi-bot merged commit a6628f7 into pingcap:release-5.4 Apr 24, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-4199-to-release-5.4 branch April 15, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@bestwoody bestwoody Awaiting requested review from bestwoody

Assignees

@fuzhe1989 fuzhe1989

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @windtalker @sre-bot @fuzhe1989 @JaySon-Huang @VelocityLight