Skip to content

Support string replace.#2060

Merged
ti-srebot merged 4 commits intopingcap:masterfrom
fuzhe1989:fuzhe/replace_master
Jun 3, 2021
Merged

Support string replace.#2060
ti-srebot merged 4 commits intopingcap:masterfrom
fuzhe1989:fuzhe/replace_master

Conversation

@fuzhe1989
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #1860

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

@fuzhe1989 fuzhe1989 requested review from fzhedu and zanmato1984 June 3, 2021 05:49
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@zanmato1984
Copy link
Contributor

@fuzhe1989 Please resolve conflicts and fix CI test failure.

@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2039
  • 2041
  • 2007
  • 2043
  • 2007
  • 2028

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit ab0bfcc into pingcap:master Jun 3, 2021
@zanmato1984 zanmato1984 added the needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 label Jun 4, 2021
@zanmato1984
Copy link
Contributor

/run-cherry-picker

@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2081

@fuzhe1989 fuzhe1989 deleted the fuzhe/replace_master branch June 12, 2021 00:37
ti-srebot added a commit that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support function replace in TiFlash

4 participants