Skip to content

Support string replace. (#2060)#2081

Merged
ti-srebot merged 4 commits intopingcap:release-5.0from
ti-srebot:release-5.0-ab0bfcc6575d
Jun 18, 2021
Merged

Support string replace. (#2060)#2081
ti-srebot merged 4 commits intopingcap:release-5.0from
ti-srebot:release-5.0-ab0bfcc6575d

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 4, 2021

cherry-pick #2060 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2081

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2081:release-5.0-ab0bfcc6575d

What problem does this PR solve?

Issue Number: close #1860

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@ti-srebot ti-srebot requested review from fzhedu and zanmato1984 June 4, 2021 03:51
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jun 4, 2021
@fuzhe1989
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuzhe1989
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 2075
  • 2076

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit 6f2b0e9 into pingcap:release-5.0 Jun 18, 2021
@fuzhe1989 fuzhe1989 deleted the release-5.0-ab0bfcc6575d branch June 18, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants