Skip to content

Fix cast string as double#1966

Merged
leiysky merged 10 commits intopingcap:v5.0.1_may_pocfrom
leiysky:feature/cast-str-as-double
May 23, 2021
Merged

Fix cast string as double#1966
leiysky merged 10 commits intopingcap:v5.0.1_may_pocfrom
leiysky:feature/cast-str-as-double

Conversation

@leiysky
Copy link
Contributor

@leiysky leiysky commented May 23, 2021 •
edited
Loading

What problem does this PR solve?

Related to #1936
Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

fzhedu
fzhedu reviewed May 23, 2021
View reviewed changes
@leiysky leiysky changed the title Fix cast string as double [DNM] Fix cast string as double May 23, 2021
fzhedu
fzhedu reviewed May 23, 2021
View reviewed changes
@leiysky leiysky changed the title [DNM] Fix cast string as double Fix cast string as double May 23, 2021
@fzhedu
Copy link
Contributor

fzhedu commented May 23, 2021

/LGTM

@ti-srebot
Copy link
Collaborator

ti-srebot commented May 23, 2021

@fzhedu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

@ti-srebot
Copy link
Collaborator

ti-srebot commented May 23, 2021

@fzhedu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

@leiysky leiysky merged commit ffa8788 into pingcap:v5.0.1_may_poc May 23, 2021
@leiysky leiysky deleted the feature/cast-str-as-double branch May 24, 2021 03:11
@leiysky leiysky mentioned this pull request May 25, 2021
Merged
@leiysky leiysky restored the feature/cast-str-as-double branch June 1, 2021 02:29
@leiysky leiysky deleted the feature/cast-str-as-double branch June 1, 2021 03:22
leiysky added a commit that referenced this pull request Jun 3, 2021
@leiysky @ti-srebot
Support cast string as double push down (#2038)
65f3920 
* support cast str as double (#1958)

* Fix cast string as double (#1966)

* support cast str as double

* fix

* fix

* fix

* fix test

* refine

* add test

* update

* fix test

* support cast str as double (#1958)

* fix

* fix

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fzhedu fzhedu fzhedu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leiysky @fzhedu @ti-srebot