Skip to content

Support cast string as double#1958

Merged
zanmato1984 merged 1 commit intopingcap:v5.0.1_may_pocfrom
leiysky:feature/cast-str-as-double
May 23, 2021
Merged

Support cast string as double#1958
zanmato1984 merged 1 commit intopingcap:v5.0.1_may_pocfrom
leiysky:feature/cast-str-as-double

Conversation

@leiysky
Copy link
Contributor

@leiysky leiysky commented May 22, 2021

What problem does this PR solve?

#1936
Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

@leiysky leiysky requested a review from windtalker May 22, 2021 06:58
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2021
@zanmato1984 zanmato1984 merged commit 540924d into pingcap:v5.0.1_may_poc May 23, 2021

func> wait_table test t

mysql> set tidb_allow_mpp=2; set tidb_isolation_read_engines='tiflash'; select a, cast(a as double) from test.t group by 1 order by a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> set tidb_allow_mpp=2;
(1231, u"Variable 'tidb_allow_mpp' can't be set to the value of '2'")

I can not set tidb_allow_mpp to 2 in tidb built by the POC branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR of enforce MPP wasn't merged in POC branch then, so I changed it to tidb_allow_mpp=1 in #1966

@leiysky
Copy link
Contributor Author

leiysky commented May 25, 2021

Related to #1792

leiysky added a commit that referenced this pull request Jun 3, 2021
* support cast str as double (#1958)

* Fix cast string as double (#1966)

* support cast str as double

* fix

* fix

* fix

* fix test

* refine

* add test

* update

* fix test

* support cast str as double (#1958)

* fix

* fix

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants