Skip to content

raft: Fix the max concurrency of IngestSST#10609

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_ingest_sst_concurrency
Dec 11, 2025
Merged

raft: Fix the max concurrency of IngestSST#10609
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_ingest_sst_concurrency

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 11, 2025

What problem does this PR solve?

Issue Number: close #10605

Problem Summary: as the issue comment describe #10605 (comment)

KVStore::preHandleSSTsToDTFiles is the common path for both PreHandleSnapshot and IngestSST, calling prehandling_trace.waitForSubtaskResources will block the max concurrency of IngestSST by the pre handle snapshot thread-pool

What is changed and how it works?

* Parse `raftstore.apply-low-priority-pool-size` in `KVStore::fetchProxyConfig`
* `KVStore::getMaxPrehandleSubtaskSize` return different max concurrency according to the job_type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    confirm that tiflash can successful parse and get the ingest sst max concurrency from tiflash-proxy
[2025/12/11 16:12:20.053 +08:00] [INFO] [KVStore.cpp:144] ["Parsed proxy config: snap_handle_pool_size=16 apply_low_priority_pool_size=72 engine_addr=10.2.12.81:9581"] [thread_id=1]

Run BR restore chbenchmark-1500

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where TiFlash could not fully utilize more than 16 CPU cores during BR restore

…y-pool-size

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 11, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang changed the title [WIP] raft: Fix the max concurrency of IngestSST raft: Fix the max concurrency of IngestSST Dec 11, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-11 09:03:47.102910669 +0000 UTC m=+1118171.916688240: ☑️ agreed by CalvinNeo.
  • 2025-12-11 09:44:40.48705822 +0000 UTC m=+1120625.300835792: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit de27831 into pingcap:master Dec 11, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #10609 on top of branch "release-8.5":

[failed to git add conflicting files: exit status 128, failed to git commit: exit status 128]

@JaySon-Huang JaySon-Huang deleted the fix_ingest_sst_concurrency branch December 11, 2025 10:32
@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-nextgen-20251011

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-nextgen-20251011: #10615.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 15, 2025
close #10605

* Parse `raftstore.apply-low-priority-pool-size` in `KVStore::fetchProxyConfig`
* `KVStore::getMaxPrehandleSubtaskSize` return different max concurrency according to the job_type

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon-Huang <tshent@qq.com>
wshwsh12 pushed a commit to wshwsh12/tiflash that referenced this pull request Feb 9, 2026
close pingcap#10605

* Parse `raftstore.apply-low-priority-pool-size` in `KVStore::fetchProxyConfig`
* `KVStore::getMaxPrehandleSubtaskSize` return different max concurrency according to the job_type

Signed-off-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IngestSST concurrency is limited to 16 under v8.5

4 participants