Skip to content

raft: Fix the max concurrency of IngestSST (#10609)#10615

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-nextgen-20251011from
ti-chi-bot:cherry-pick-10609-to-release-nextgen-20251011
Dec 15, 2025
Merged

raft: Fix the max concurrency of IngestSST (#10609)#10615
ti-chi-bot[bot] merged 4 commits intopingcap:release-nextgen-20251011from
ti-chi-bot:cherry-pick-10609-to-release-nextgen-20251011

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10609

What problem does this PR solve?

Issue Number: close #10605

Problem Summary: as the issue comment describe #10605 (comment)

KVStore::preHandleSSTsToDTFiles is the common path for both PreHandleSnapshot and IngestSST, calling prehandling_trace.waitForSubtaskResources will block the max concurrency of IngestSST by the pre handle snapshot thread-pool

What is changed and how it works?

* Parse `raftstore.apply-low-priority-pool-size` in `KVStore::fetchProxyConfig`
* `KVStore::getMaxPrehandleSubtaskSize` return different max concurrency according to the job_type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    confirm that tiflash can successful parse and get the ingest sst max concurrency from tiflash-proxy
[2025/12/11 16:12:20.053 +08:00] [INFO] [KVStore.cpp:144] ["Parsed proxy config: snap_handle_pool_size=16 apply_low_priority_pool_size=72 engine_addr=10.2.12.81:9581"] [thread_id=1]

Run BR restore chbenchmark-1500

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where TiFlash could not fully utilize more than 16 CPU cores during BR restore

…y-pool-size

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 01:53:17.668544934 +0000 UTC m=+1437942.482322496: ☑️ agreed by JaySon-Huang.
  • 2025-12-15 02:40:28.221599561 +0000 UTC m=+1440773.035377133: ☑️ agreed by JinheLin.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

@yinshuangfei: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, yinshuangfei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 566fb98 into pingcap:release-nextgen-20251011 Dec 15, 2025
2 of 4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-10609-to-release-nextgen-20251011 branch December 15, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants