PageStorage: Fix tiflash wn oom issue by introducing DeltaTreeOnlySnapshot (#10410)#10448
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@JaySon-Huang This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: JaySon-Huang <tshent@qq.com>
d78f7f1 to
141c7c6
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
ref pingcap#6233 Storage: Cleanup StoragePool interface * Remove useless newLogReader interface from StoragePool * Remove useless always true `snapshot_read` param from StorageSnapshot * Refine unit tests of PageStorageMixedTest Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/unhold |
This is an automated cherry-pick of #10410
What problem does this PR solve?
Issue Number: close #10382, close #10278
Problem Summary:
Slow query requests prevent the release of PageStorage snapshots, causing persistent issues where multi-versioned data in PageStorage memory and multi-versioned columnar storage data on disk cannot be compacted. However, under the storage-compute separation architecture, TiFlash aims to support the capability of restoring new Region replicas from S3 , which motivates storing high-frequency write-and-delete data such as RaftLog into PageStorage. As a result, with Raft messages sustained at 12K QPS, a 10-minute-long query causes the number of Pages in PageStorage to increase by 7.2 million and the number of multi-versions to rise by 17.8 million. Due to the design of PageStorage, this leads to an additional 6 GB of memory consumption, and may also be accompanied by degraded read and write performance in PageStorage.
What is changed and how it works?
Manual Testing result
According to the test result
Check List
Tests
described as above
Side effects
Documentation
Release note